0.8.0 Beta 1 - Grabbing ZIP from RSS

[blink]

I have a RSS feed pointing to compressed NZB files, the beta fails to grab every one of these files. The URL is https://host/nzb/get/40105.zip?apikey=#######

Code: Select all

URLGRABBER CRASHED
Traceback (most recent call last):
File "/usr/share/sabnzbdplus/sabnzbd/urlgrabber.py", line 231, in run
nzo_id=future_nzo.nzo_id)[0]:
File "/usr/share/sabnzbdplus/sabnzbd/dirscanner.py", line 77, in ProcessArchiveFile
if zipfile.is_zipfile(path):
File "/usr/lib/python2.7/zipfile.py", line 150, in is_zipfile
result = _check_zipfile(fp=filename)
File "/usr/lib/python2.7/zipfile.py", line 136, in _check_zipfile
if _EndRecData(fp):
File "/usr/lib/python2.7/zipfile.py", line 208, in _EndRecData
fpin.seek(0, 2)
AttributeError: addinfourl instance has no attribute 'seek'

Header from web server

Code: Select all

HTTP/1.1 200 OK
Server: nginx/1.8.0
Date: Mon, 05 Oct 2015 00:42:37 GMT
Content-Type: application/zip
Transfer-Encoding: chunked
Connection: keep-aliveStrict-Transport-Security: max-age=63072000

X-Powered-By: PHP/5.5.9-1ubuntu4.13
Content-Disposition: attachment; filename="----------------.zip"
X-Frame-Options: DENY
X-Content-Type-Options: nosniff

[shypike]

Likely an unsupported ZIP format or a damaged ZIP file.
SABnzbd bails out inside the standard Python library, not something we can fix.
Can you PM the real link of the indexer, so that we can check?

[shypike]

I cannot download anything from that server.
It seems it using some unusual SSL protocol, not supported by the Python libraries.

[shypike]

Forgot to ask.
Does SABnzbd 0.7.20 work with this indexer?
(It doesn't for me.)

[johanviv]

Hi

I am getting the same error, not sure if it's from the same site:

URLGRABBER CRASHED Traceback (most recent call last): File "/usr/share/sabnzbdplus/sabnzbd/urlgrabber.py", line 231, in run nzo_id=future_nzo.nzo_id)[0]: File "/usr/share/sabnzbdplus/sabnzbd/dirscanner.py", line 77, in ProcessArchiveFile if zipfile.is_zipfile(path): File "/usr/lib/python2.7/zipfile.py", line 149, in is_zipfile result = _check_zipfile(fp=filename) File "/usr/lib/python2.7/zipfile.py", line 135, in _check_zipfile if _EndRecData(fp): File "/usr/lib/python2.7/zipfile.py", line 203, in _EndRecData fpin.seek(0, 2) AttributeError: addinfourl instance has no attribute 'seek'

It is trying to download a valid url and nzb file, and I can download it with wget.
It worked before with version 0.6.15-1, but if I downgrade now it still doesn't work.

Thanks

[shypike]

It's guessing, but my guess is that the website set the minimum SSL level to TLS 1.2
Many Python versions (or probably rather the OpenSSL libraries they use) do not properly support that protocol level.
Older versions probably won't work either.

[johanviv]

did a clean install of 0.6.15-1 and it's working now

[sander]

did a clean install of 0.6.15-1 and it's working now

On which OS, with which python version?
Can you share the URL of the RSS site?

[johanviv]

scratch that, still not working.
I'll pm the url to you, please don't share

[sander]

Quick analysis based on johanviv's URL (plain HTTP, not HTTPS): problem is indeed there in 0.8.0 Beta1, and/but already solved in 0.8.0-git-version, so also in the upcoming 0.8.0 Beta2.

Git patch: https://github.com/sabnzbd/sabnzbd/comm ... 38f9ce00f7

[blink]

Regarding HTTPS, it seems to be working with python 2.7.10 for TLSv1.

Also, applying the patch resolves the zip file error.