Bug/Differences?

[LV-426]

I've just upgraded from 0.7.20 to the latest and noticed a couple of differences.

First is when you use the Download button from within a feed, it no longer sends the priority you have set in that feed, at least if you have default set.

Second is with items dropped in the watch folder, they no longer receive default priority, so if like me you run pre-queue script for category sorting, priorities you have set in categories are ignored.

It's not a big issue for me, I just added a line to my pre-queue script to set default priority if none exists, which solves the problem.

You can see when the pre-queue runs there's no priority set with 2.3.1 in both instances

Code: Select all

RSS Download Button Version 0.7.20

2017-11-08 13:35:15,405::INFO::[urlgrabber:116] Grabbing URL https://
2017-11-08 13:35:18,464::INFO::[newsunpack:1561] Running pre-queue script C:\Users\DrWho\AppData\Local\sabnzbd\POSTPR~1\CATAGO~1.BAT Film.Title.2017.720p.BluRay.X264-AMIABLE "" movies "" -100 3999260894 "alt.binaries.moovee" "" "" "" ""

RSS Download Button Version 2.3.1

2017-11-08 13:49:49,210::INFO::[urlgrabber:115] Grabbing URL https://
2017-11-08 13:49:53,467::INFO::[newsunpack:2270] Running pre-queue script C:\Users\DrWho\AppData\Local\sabnzbd\POSTPR~1\CATAGO~2.BAT Film.Title.2017.720p.BluRay.X264-AMIABLE "" movies "" "" 3999260894 "alt.binaries.moovee" "" "" "" ""


Watch Folder Version 0.7.20 

2017-11-08 13:28:57,999::INFO::[dirscanner:325] Trying to import X:\SABnzbd\Watch Folder\Film.Title.2017.720p.BluRay.X264-AMIABLE.nzb.gz
2017-11-08 13:29:01,542::INFO::[newsunpack:1561] Running pre-queue script C:\Users\DrWho\AppData\Local\sabnzbd\POSTPR~1\CATAGO~1.BAT Film.Title.2017.720p.BluRay.X264-AMIABLE "" "" "" -100 3999260894 "alt.binaries.moovee" "" "" "" ""

Watch Folder Version 2.3.1

2017-11-08 13:54:04,999::INFO::[dirscanner:378] Trying to import X:\SABnzbd\Watch Folder\Film.Title.2017.720p.BluRay.X264-AMIABLE.nzb.gz
2017-11-08 13:54:08,049::INFO::[newsunpack:2270] Running pre-queue script C:\Users\DrWho\AppData\Local\sabnzbd\POSTPR~1\CATAGO~2.BAT Film.Title.2017.720p.BluRay.X264-AMIABLE "" "" "" "" 3999260894 "alt.binaries.moovee" "" "" "" ""

[safihre]

Sorry for the delay, wasn't near my computer

So I checked and did some digging and to me it seems the behavior is now the way it should be:
The category is first processed before the Pre-Q script is started, so if the category is set to Default and the default-category priority setting is Normal it will already have that value of 0. If the Pre-Q script doesn't return anything, it stays that way. If the Pre-Q script returns a new category and that category has a higher priority than before, it will use that new priority.

Unfortunately there is a bug that causes 0 (= Normal Priority) not to be send to the Pre-Q script, that's probably why you see the "".
This I will fix for the next release

If you did not put that -100 in your script, what unexpected behavior did you get? What priority should it have gotten and what priority did it get instead?

[LV-426]

You have described how I expect it to work at least on the feed.

I have Movies in Categories set to High priority.

I have a Movie feed with priority set to Default on the feed, when you use the "download button" in the feed to add items to queue it sets "" not -100, so movies get added to queue with Normal priority?

When movies get added to queue from the feed automatically they do get -100, so movies get added to queue with High priority, matching priority in Categories.

I'm not sure how the watch folder is meant to work only that it's different to the older versions and I haven't change anything, the older versions set -100 on anything I put in the watch folder, when the pre-scripted categorised as a movie it would then get High priority matching priority in Categories, because it's getting "" again it gets Normal priority.

Original Pre-script didn't do anything with priority, now it only sets -100 if priority is ""

On another note is folder_max_length still working, mine is still set to 128 but it seems to be using 64.

Anyway thanks for your time.

[safihre]

Could you email me a screenshot of your Category and Feed settings? Easier to understand and test for me.
[email protected]

[safihre]

Oke I dug deeper and I found the problem.
It was some ancient code that used to work fine but was affected by a small change in some distant code that I never expected would affect this.
It will be fixed for the next release

[LV-426]

Sorry if I gave you a headache, I did try to be as clear as possible

What about folder_max_length, that would be the reason for not having the full folder name if I'm understanding it correctly? that's 64 characters below right? when I have it set to 128.

Code: Select all

INFO::[misc:943] Creating directories: \\?\X:\SABnzbd\Incomplete\Ms.Pebot.S03E05.720p.AMZN.WEBRip.DD5.1.x264-

Anyway thanks again

[safihre]

Yes, that's a safety measure. The folder_max_length applies to the final foldername, not to the incomplete name.
The reason being that Unrar and Par2 do not fully support Windows long-path notation, so just to be sure we keep those paths as short as possible.
You can read more about it here: https://github.com/sabnzbd/sabnzbd/issues/368
With the example of "Late.Show.with.Stephen.Colbert.2015.10.13.Sarah.Silverman.Elijah.Wood.The.Legend.of.Zelda.Symphony.of.the.Goddesses.720p.CBS.WEB.rar" given there and a longer temp-folder path UnRar will fail.

Shouldn't really be a problem, as long as the filenames in the temp-folder are somewhat identifiable

[LV-426]

Understood, I guess I never ran into any crazy long file names in 0.7.20 or earlier.

Didn't realize how far behind my version was, I tend not to upgrade though if its working perfectly.

Thanks