Post processing errors after updating to 2.3.7

[drizzt09]

Getting errors during post processing after updating to 2.3.7

Code: Select all

2019-01-21 09:06:57,558::ERROR::[postproc:537] Post Processing Failed for ********************************* (see logfile)
2019-01-21 09:06:57,558::INFO::[postproc:538] Traceback: 
Traceback (most recent call last):
  File "sabnzbd\postproc.pyo", line 502, in process_job
  File "sabnzbd\emailer.pyo", line 255, in endjob
  File "sabnzbd\emailer.pyo", line 206, in send_with_template
  File "Cheetah\Template.pyo", line 1259, in __init__
  File "Cheetah\Template.pyo", line 1553, in _compile
  File "Cheetah\Template.pyo", line 743, in compile
  File "Cheetah\Compiler.pyo", line 1672, in compile
  File "Cheetah\Parser.pyo", line 1489, in parse
  File "Cheetah\Parser.pyo", line 1619, in eatDirective
  File "Cheetah\Parser.pyo", line 1724, in eatSimpleIndentingDirective
  File "Cheetah\Parser.pyo", line 1210, in getExpression
  File "Cheetah\Parser.pyo", line 1187, in getExpressionParts
  File "Cheetah\Parser.pyo", line 1210, in getExpression
  File "Cheetah\Parser.pyo", line 1174, in getExpressionParts
  File "Cheetah\Parser.pyo", line 562, in getPyToken
ParseError: 

Invalid Syntax
Line 25, column 17

Line|Cheetah Code
----|-------------------------------------------------------------
22  |הורדו $size
23  |
24  |:תוצאות העבודה
25  |<!--#for $stage ב $stages #-->
                     ^
26  |שלב $stage <!--#slurp#-->
27  |<!--#for $result ב $stages[$stage]#-->
28  |    $result <!--#slurp#-->

And then it sends me 4 emails (same email but 4 different languages):

Code: Select all

2019-01-21 09:07:00,348::INFO::[emailer:150] Notification e-mail successfully sent
2019-01-21 09:07:00,348::DEBUG::[emailer:80] Connecting to server smtp.gmail.com:587
2019-01-21 09:07:00,450::DEBUG::[emailer:93] Non-SSL mail server detected reconnecting to server smtp.gmail.com:587
2019-01-21 09:07:00,586::DEBUG::[emailer:107] TLS mail server detected
2019-01-21 09:07:01,619::INFO::[emailer:150] Notification e-mail successfully sent
2019-01-21 09:07:01,619::DEBUG::[emailer:80] Connecting to server smtp.gmail.com:587
2019-01-21 09:07:01,720::DEBUG::[emailer:93] Non-SSL mail server detected reconnecting to server smtp.gmail.com:587
2019-01-21 09:07:01,905::DEBUG::[emailer:107] TLS mail server detected
2019-01-21 09:07:03,871::INFO::[emailer:150] Notification e-mail successfully sent
2019-01-21 09:07:03,888::DEBUG::[emailer:80] Connecting to server smtp.gmail.com:587
2019-01-21 09:07:03,993::DEBUG::[emailer:93] Non-SSL mail server detected reconnecting to server smtp.gmail.com:587
2019-01-21 09:07:04,194::DEBUG::[emailer:107] TLS mail server detected
2019-01-21 09:07:05,599::INFO::[emailer:150] Notification e-mail successfully sent
2019-01-21 09:07:05,599::DEBUG::[emailer:80] Connecting to server smtp.gmail.com:587
2019-01-21 09:07:05,716::DEBUG::[emailer:93] Non-SSL mail server detected reconnecting to server smtp.gmail.com:587
2019-01-21 09:07:05,894::DEBUG::[emailer:107] TLS mail server detected
2019-01-21 09:07:06,997::INFO::[emailer:150] Notification e-mail successfully sent

Followed by Sab forcing itself into a restart due to a crash:

Code: Select all

2019-01-21 09:07:20,032::INFO::[__init__:1065] Restarting because of crashed postprocessor
2019-01-21 09:07:20,032::INFO::[__init__:772] [SABnzbd.py.main] Performing SABnzbd shutdown
2019-01-21 09:07:20,032::INFO::[__init__:385] SABnzbd shutting down...

Full log here: https://www.dropbox.com/s/bynxxf4hghsco ... d.log?dl=0

[safihre]

Did you update from 2.3.6 or an earlier version?

[safihre]

I see the Hebrew template was changed.
Is your SAB set to Hebrew?

[sander]

I see Hebrew (?) text in your output. So, checking: you have set SAB / Windows to Hebrew?

If so: there is also a Hebrew character (" ב ") in the for statement in line 25 ... my guess is that that is not correct.

It seems that the word "in" in "for $stage in $stages" (line 25) was translated to " ב ". Maybe caused by an overactive translating system / person?

[sander]

Ah, wrong in the SAB source: https://github.com/sabnzbd/sabnzbd/blob ... /he.po#L94

and here too: https://github.com/sabnzbd/sabnzbd/blob ... /he.po#L96

[drizzt09]

Everything is straight up English everywhere.
I "think" i upgraded from 2.3.5, skipping 2.3.6 directly to 2.3.7

Your comment of:
Ah, wrong in the SAB source: https://github.com/sabnzbd/sabnzbd/blob ... /he.po#L94
and here too: https://github.com/sabnzbd/sabnzbd/blob ... /he.po#L96

Does that mean you found the issue?

FYI, I checked the files. They did successfully download and unpack. They did not rename or move to final location.
So I manually did that.
I set email notifications to "NEVER" and now all processing happens fully (just no notification obviously)

[safihre]

Could you maybe delete the file:
C:\Program Files\SABnzbd\email\email-he.tmpl
See if that works.

Very strange you get this error when your language is set to English.

[drizzt09]

is there a setting in Sab for language.. its all showing in English and Windows has only ever had English but i dont see any language setting in Sab.

So I renamed the 3 -he.tmpl files to -he.tmpl.bad
I reenabled email notifications and sent the test option and got 14 emails in different languages.
The hebrew one may be the one breaking it but it shouldnt be sent in the first place, as well as the other 13 languages.
It appears its sending all languages (before it just crashed on hebrew and stopped, now its doing all the languages.....but why?)

[drizzt09]

also only appears to affect email. Windows notifications work fine. only 1 and in English

[safihre]

Aah.
Have you set "Email Templates Folder"?
You should leave that empty.

[drizzt09]

Aah.
Have you set "Email Templates Folder"?
You should leave that empty.

yes i have had that set to C:\Program Files\SABnzbd\email for at least 2 years.
why have the option if it shouldnt be set?

[safihre]

It should only be set if you want custom templates.
This behavior is listed on the wiki, but very very hidden: https://sabnzbd.org/wiki/extra/email-templates

I think I will move this setting to "Advanced settings".
For some reason it's also both on the "Notifications" and "Folders" page, which is weird.

[drizzt09]

never noticed it was in both locations. I only had path set in the notifications tab... not both.
I have removed it and its working now. single email only.. in english
thanks