Scripts not working

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
kallek
Newbie
Newbie
Posts: 21
Joined: January 8th, 2011, 5:22 pm

Scripts not working

Post by kallek »

Since updating Sabnzbd to 4.2.1 on my Qnap nas, scripts don't work.

When I go to the dropdown list "On queue finish", the only available option is Shutdown SABnzbd. All the other scripts in the scripts folder don't show up. I checked the location of the scripts folder in the folders menu and it is correct (Default). The scripts are still in the folder, so I don't know why they don't show up.

I am not alone to have this problem:

https://forum.qnap.com/viewtopic.php?p=857645#p857645
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

#Metoo! :)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
safihre
Administrator
Administrator
Posts: 5524
Joined: April 30th, 2015, 7:35 am
Contact:

Re: Scripts not working

Post by safihre »

This part of the code didn't change.. We just run a simple listing of the files on your selected folder.
It checks if you have Read permissions and the X bits have been set on the scripts.
https://github.com/sabnzbd/sabnzbd/blob ... em.py#L587
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

Just did a test: went back to SABnzbd 4.1.0 (running from source), and it correctly lists my scripts in the same environment 4.2.1 doesn't.

I'll continue checking the later releases and see if I can find out where it stopped working.
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

update:
  • works in 4.2.0Alpha1
  • works in 4.2.0Alpha2
  • not working in 4.2.0Alpha3
  • not working in 4.2.0Beta1
If filesystem.py hasn't changed, maybe it’s the interface?
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

Might be this? https://github.com/sabnzbd/sabnzbd/comm ... b7f5a7f00a

It looks like 'interfaces/Glitter/templates/include_menu.tmpl' had some changes related to end-of-queue operations.
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

Ah, I now realise this selection box was moved from the front SABnzbd page, into Config -> Switches -> Queue -> On queue finish script.

So, not a bug, just a change.

:)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
User avatar
safihre
Administrator
Administrator
Posts: 5524
Joined: April 30th, 2015, 7:35 am
Contact:

Re: Scripts not working

Post by safihre »

It's in the 4.2.0 release notes which is also part of the 4.2.1 release notes :)
If you like our support, check our special newsserver deal or donate at: https://sabnzbd.org/donate
User avatar
OneCD
Hero Member
Hero Member
Posts: 598
Joined: March 4th, 2017, 3:47 pm

Re: Scripts not working

Post by OneCD »

I even post those release notes on the QNAP forum. I should probably read them a little closer though. ;)
Stuff I like: Apache bash cron DD-WRT Debian DNSMasq Entware FireFox GitHub ImageMagick Kate KDE LibreELEC Netrunner NFS NVIDIA OpenVPN Orvibo-S20 pfSense Python Raspberry-Pi RAID SABnzbd Transmission Usenet VirtualBox Watcher3 XFCE
Post Reply