RSS - Make duplicate download optional

Want something added? Ask for it here.
Post Reply
Beave
Release Testers
Release Testers
Posts: 15
Joined: January 28th, 2008, 5:40 pm

RSS - Make duplicate download optional

Post by Beave »

Hi,

since newzbin names all the different versions of an episode the same I see no way of getting the proper or repacks.
I'm missing a checkbox in the configs where SABnzbd could fill the queue with everything in that rss feed, not just the first one it finds. (Maybe even per feed?)

The prefiltering is pretty good in newzbin, so I don't worry about too many false hits. The only problem is if episodes reappear after a few month, so I have to worry about updating my feeds or deleting them from the queue...
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: RSS - Make duplicate download optional

Post by shypike »

Switch off duplicate checking (Config->Options) and match on '*'.
As the initial batch of a new feed is ignored, you will have to do a forced download
of that batch (just press "download").
Beave
Release Testers
Release Testers
Posts: 15
Joined: January 28th, 2008, 5:40 pm

Re: RSS - Make duplicate download optional

Post by Beave »

Thanks for your reply, but unfortunately I can't find Config -> Options in 0.4.11.
Config -> Switches would fit I guess, but nothing like that in there.  :(
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: RSS - Make duplicate download optional

Post by shypike »

It's indeed called Config->Switches.
The switch you need to set "off" is called "Do not download same job twice".
Beave
Release Testers
Release Testers
Posts: 15
Joined: January 28th, 2008, 5:40 pm

Re: RSS - Make duplicate download optional

Post by Beave »

Hmm, it was already unchecked!
When I click on Preview in RSS I can see dublicate eps, but if I hit Force Download it only gets one of those doubles.
Any Idea why?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: RSS - Make duplicate download optional

Post by shypike »

It could be because of this problem:
Ticket 290 "RSS Preview is confusing"
The RSS preview shows all the NZB files SABnzbd has in its memory.
However the filters are only applied to the NZBs that are in the RSS feed now.
They are not applied to what's in the memory from previous scans.
The reason it works like this, is that it tries to show you what is happening when an automated scan is done.

The problem is of course that the preview does show the NZB files that are no longer present in the RSS feed.
But then again, if it doesn't, you will not be able to manually download them either.

Somehow the function has to become clearer for the user.
The purpose of the preview is to show what the filters will do on the current feed. I think the jobs dropped by the feed should not be shown at all.
It will be solved in release 0.4.12
Beave
Release Testers
Release Testers
Posts: 15
Joined: January 28th, 2008, 5:40 pm

Re: RSS - Make duplicate download optional

Post by Beave »

When I navigate to that url via browser I do see the dublicates (like in the preview). Not sure if this applies to that ticket or not.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: RSS - Make duplicate download optional

Post by shypike »

When you enter the feed URL in the browser and you see duplicates,
they must be in the feed itself, so you should see them in SABnzbd too.

After reviewing the sourcecode, I see that duplicates are detected twice.
The RSS handler itself checks for duplicate titles. It will not send jobs to the queue
that have 100% identical titles. This is not a selectable option.
When a job enters the queue its name is checked against what is
in the NZB backup folder. This is controlled by the option in Config->Switches.

Maybe we should do the first check only when the option is on?
Few people would want to download duplicates anyway.
Beave
Release Testers
Release Testers
Posts: 15
Joined: January 28th, 2008, 5:40 pm

Re: RSS - Make duplicate download optional

Post by Beave »

Thank you for checking! So this is my change request then: Make it optional to download dublicate rss feed entries even if the names are 100% identical.

Using newzbin every episode has the same name (but a different msgid). No matter if it is 720p, xvid, dvdrip, vcd, proper, repack, bluray and so on...
In newzbin I can filter pretty good for those properties. If I only want the 720p ones I can make a stream that only has those in it. If it has dublicate ones it usually because it is a proper or repack. Of course, after a while they might be reupped again, but by that time I have to make sure to change or disable the stream or make changes to the regex.

And even if dublicates find the way into the queue I could still delete them there.
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: RSS - Make duplicate download optional

Post by shypike »

It's filed as Ticket 321 (https://trac2.assembla.com/SABnzbd/ticket/321).
It will not be solved in release 0.4.12, but only in 0.5.0.
Post Reply