Joined items are not always cleaned up

barlow · Post by **barlow** » October 12th, 2009, 10:05 am

Some items which are joined by par2 are not cleaned up afterwards.

So the *.xx files are still there. If this happens, there also is no mention of stage filejoin in the history.
If this stage is present, the files are deleted.
I think it is related to the first file of fileset to be joined: if the first file is *.001 the filejoin stage is performed,
but if the first file is *.000 it is not.

An example of a post where the files are not deleted is Newzbin ID 5164326.

Other relevant stuff:
SABnzbd 0.4.12
Operating systems: Windows 7 x64 and Mac OS X 10.6.1

pspgimp · Post by **pspgimp** » October 17th, 2009, 5:11 am

Firstly can I say what an excellent piece of work Sabnzbd is, along with nzb-tv it has revolutionized my usenet use ! thanks for that mate !

I too am having problems thought since the last two updates, everything was working fine, but since then I have the downloaded files left in the folder along with the unpacked file.

I hope you can help.

Post by **shypike** » October 17th, 2009, 1:31 pm

Yes, we must look into this.
I suspect the par2 sometimes does it's own joining,
before SABnzbd has a chance to do it.
Filed as Ticket #330.

Post by **shypike** » October 17th, 2009, 1:39 pm

pspgimp wrote: I too am having problems thought since the last two updates, everything was working fine, but since then I have the downloaded files left in the folder along with the unpacked file.

I do need some information.
Is the problem similar to waht is described by barlow?
What happens exactly?

pspgimp · Post by **pspgimp** » October 17th, 2009, 4:47 pm

I have some stuff queued up right now so I will see what happens with that, but basically all the rar files are left in the "correct" folder for the episode downloaded, the avi is there also.

I will have a look what heppens with the ones queued and get back to you in the morning.

Cheers

PSPgimp

pspgimp · Post by **pspgimp** » October 18th, 2009, 3:22 am

OK, now got some input for you.

I was downloading "Some Show", and 2 episodes in particular 4 and 5

Some Show - 1x05 - Season 1, Episode 5 Completed
Stage Download
[Time-Taken]: 52 minutes 3 seconds
[Avg-Speed]: 120kB/s
Stage Par2
[PAR-INFO] aaf-btit.105: => Verified in 5.6s, all files correct
[DEL-INFO] aaf-btit.105: => Deleted 2 file(s)
Stage Unrar
[RAR-INFO] aaf-btit.105: => Unpacked 1 files/folders in 2.9s
Stage UserScript
[USER-SCRIPT]: => Show script output

Some Show - 1x04 Completed
Stage Download
[Time-Taken]: 51 minutes 22 seconds
[Avg-Speed]: 120kB/s
Stage Par2
[PAR-INFO] aaf-btit.104: => Verified in 11.3s, all files correct
[DEL-INFO] aaf-btit.104: => Deleted 2 file(s)
Stage Unrar
[RAR-INFO] aaf-btit.104: => Unpacked 1 files/folders in 3.4s
[DEL-INFO] aaf-btit.104: => Deleted 25 file(s)
Stage UserScript
[USER-SCRIPT]: => Show script output

IN each case there were .rar files as well as .r00, r02 files.

Hope this helps.

PSPgimp

Post by **shypike** » October 18th, 2009, 4:55 pm

shypike wrote: I suspect the par2 sometimes does it's own joining,
before SABnzbd has a chance to do it.
Filed as Ticket #330.

Well, I found out what's going on.
The post uses a rarely used option of par2, where par2 sees
the .000, .001 etc. files not as joinable segments but
carriers of correction blocks. Just like .par2 files are.
The end result (the joined .mkv file) is "missing" and
the par2 program will reconstruct it using the .000 etc. parts.

SABnzbd has had support for this since its early days, but
the original author forgot to add code for deleting the .000 files.

We will fix this, but not in the 0.4.x releases.
It will be done for 0.5.0.

Post by **shypike** » October 18th, 2009, 4:58 pm

pspgimp wrote: OK, now got some input for you.
I was downloading "Some Show", and 2 episodes in particular 4 and 5
PSPgimp

We need the NZB files to diagnose this properly.
Please email to [email protected] with a reference to this post.

PS.
You are not allowed to use actual names of TV shows on the forum.

barlow · Post by **barlow** » October 19th, 2009, 5:07 am

shypike wrote: We will fix this, but not in the 0.4.x releases.
It will be done for 0.5.0.

Great! SAB FTW!

Post by **shypike** » October 19th, 2009, 6:45 am

pspgimp wrote: OK, now got some input for you.
I was downloading "Some Show", and 2 episodes in particular 4 and 5

Not sure what's going on here.
But be aware that sometimes NZB files contain files that are not
really part of the download.
Only files that have been succesfully processed by par2
and (if needed) by unrar, will be deleted.
I still need the NZB to tell you more.

pspgimp · Post by **pspgimp** » October 19th, 2009, 12:56 pm

shypike wrote:
pspgimp wrote: OK, now got some input for you.
I was downloading "Some Show", and 2 episodes in particular 4 and 5
PSPgimp
We need the NZB files to diagnose this properly.
Please email to [email protected] with a reference to this post.

PS.
You are not allowed to use actual names of TV shows on the forum.

I have sent over a couple of NZB files for you to check out, sorry about the show names won't happen again

Post by **shypike** » October 19th, 2009, 1:59 pm

pspgimp wrote: I have sent over a couple of NZB files for you to check out,

One job (4997061) contains a RAR file in a segmented RAR-file.
SABnzbd unpacks the first layer, ending up with a single RAR file.
When unpacking of this file is attempted, things go wrong, because the second RAR file needs a password.

Post by **shypike** » October 19th, 2009, 3:36 pm

pspgimp wrote: I have sent over a couple of NZB files for you to check out,

One job (4997061) contains a RAR file in a segmented RAR-file.
SABnzbd unpacks the first layer, ending up with a single RAR file.
When unpacking of this file is attempted, things go wrong, because the second RAR file needs a password.

The other one (4996209) downloads and unpacks fine.

Both files need not be "joined", they are multi-volume RAR files,
which are handled by unrar and not by par2.

Can you describe what happens exactly on your system?

pspgimp · Post by **pspgimp** » October 21st, 2009, 6:36 am

shypike wrote:
pspgimp wrote: I have sent over a couple of NZB files for you to check out,
One job (4997061) contains a RAR file in a segmented RAR-file.
SABnzbd unpacks the first layer, ending up with a single RAR file.
When unpacking of this file is attempted, things go wrong, because the second RAR file needs a password.

The other one (4996209) downloads and unpacks fine.

Both files need not be "joined", they are multi-volume RAR files,
which are handled by unrar and not by par2.

Can you describe what happens exactly on your system?

Sorry they weren't good examples, I emailed over 3 more this morning that did not clean up correctly, as I say it could be that it's a co-incidence that things are not being packed the same way they used to be by posters, but it has only been an issue since I installed SABnzbd+ 0.4.11 and 0.4.12

Cheers

PSPgimp

Support Forum

Joined items are not always cleaned up

Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up

Re: Joined items are not always cleaned up