0.3.4 "t;" history glitch

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
User avatar
trax
Release Testers
Release Testers
Posts: 7
Joined: February 1st, 2008, 2:31 pm

0.3.4 "t;" history glitch

Post by trax »

Because of the history text having t; before each line, themes are not showing icons only anymore.
This was not a problem in 0.3.3.

This annoyance is showing up in plush, and nova themes.

What file can I modify to fix this myself?
I am running python, not the w32 exe.
DeXeS
Release Testers
Release Testers
Posts: 206
Joined: January 28th, 2008, 1:04 pm
Location: The Netherlands

Re: 0.3.4 "t;" history glitch

Post by DeXeS »

Im having the same t in the history and could not find where it is located... it's not in the template..
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: 0.3.4 "t;" history glitch

Post by shypike »

Release 0.3.4 converts the characters '' and '&' in history status strings to proper HTML codes: > < and &.
This prevents other problems.
However it looks like the SMPL and Plush designers took a shortcut in scanning strings to do clever things with it.

Since I'm not very familiar with these templates, I suggest you change back the Python code.
In release 0.3.4, it's in the file interface.py. Line 661 now reads:

        actionLine = {'name':escape(action), 'value':escape(unpackstrht[stage][action])}

change it to:

        actionLine = {'name':escape(action), 'value':unpackstrht[stage][action]}

I'll notify the template designers.
User avatar
trax
Release Testers
Release Testers
Posts: 7
Joined: February 1st, 2008, 2:31 pm

Re: 0.3.4 "t;" history glitch

Post by trax »

I don't know what other problems this can cause, but it should be fine for now.

Thanks for the quick code-fix solution, shypike.
Post Reply