Multiple Group In NZB Issue

[durin]

Version: 0.5.2
OS: windows vista 32bit
Install-type: Windows Installer
Skin (if applicable): smpl
Firewall Software: none
Are you using IPV6? no
Is the issue reproducible? yes

I have to issue the GROUP command for my usenet provider.  On some nzbs there are multiple groups listed.  Ex:

   
      alt.binaries.teevee
      alt.binaries.multimedia
   

In this particular case, my provider has the second group (alt.binaries.multimedia) but does not have the first (alt.binaries.teevee).  SAB is only issuing the command on the first group listed, and then is not able to pull the article since the group does not exist on my server.  It does not try to use the second group.  If I manually edit the nzb and remove the first group in the list it works.

I believe a better way to do this would be if you have the "Send group command before requesting articles" switch checked sabnzbd should try to pull the article from all the groups listed in the "groups" loop, not just the first one.

[shypike]

In the three years I'm active in SABnzbd,  this the first time anyone complained about this.
It's very unusual for a provider to even require the group command nowadays.

Given the amount of work this would take in places in the source code
where we do not like to go, it's very unlikely to be fixed.

[durin]

Thanks shypike I appreciate the reply.

I agree my newgroup provider is unusual.  I have been using them and sabnzbd for years as well until recently - now it seems like a lot of stuff I am downloading is getting cross-posted to the group they do not have on the server which has been really annoying.  Unfortunately I prepaid for a year so I am not quite ready to leave them yet.

I ended up uninstalling the Windows compiled version and running sabnzbd from source.  I make a dirty hack to temporarily fix the immediate issue for me which was cross-postings this particular group, perhaps if I get some time I will do it the right way and submit a patch.

downloader.py:

Code: Select all

    def __request_article(self, nw):
        try:
            if cfg.send_group() and nw.article.nzf.nzo.get_group() != nw.group:
                group = nw.article.nzf.nzo.get_group()
                #add this code
                if group == 'alt.binaries.teevee':
                        group = 'alt.binaries.multimedia'
                #end add this code
                logging.info('Thread %s@%s:%s: GROUP <%s>',
                             nw.thrdnum, nw.server.host,
                             nw.server.port, group)
                nw.send_group(group)

[shypike]

I'm now working on pre-queue user-scripts for release 0.6.0.
That might also become a way of solving this issue.