Single history entry deletion

[n2k]

Hey,

When clicking the delete button on an entry in the history it currently asks me if I want to delete the NZB or the NZB and files (greyed out most of the time, not sure what criteria this is based on).
I'd like this to change to one of these suggestions:

1. When clicking the delete button and you cannot choose to delete both the NZB and files, default the action to deleting the NZB, if you can show the current option window.
2. Left clicking will only delete the NZB, right-clicking (maybe middle-click) will delete both the NZB and files (if possible, this could be shown via a tooltip, or color/outline of the delete button).

Personally I'd prefer #2. and maybe add a switch in the options somewhere to control this behavior.

Another thing that you might want to consider, is letting the user select any number of entries by dragging a selection box and just pressing the delete key

----------

Another small suggestion:
Clicking warnings or clicking Status will go the same page (top left of the Downloads page), maybe you could change when clicking warnings it will clear (delete) them.

Both suggestions are meant for the Plush skin =]

Greets,
n2k

[shypike]

Entries in history are either completed or failed/retry-able.
In the latter case, the unprocessed downloaded files are still available
and can be optionally deleted.

Making Plush nicer is of later concern, after we reach a release with
stable functionality.
#2 doesn't sound very intuitive to me.

[n2k]

Changed it myself, it was annoying me that much

I changed the behavior of the delete button, it will now Remove NZB directly on the first click for successful downloads (no popup box / confirmation).
The popup box with the option to Remove NZB or NBZ+Files will still be there for failed downloads and downloads in the queue when clicking the delete button.
If anybody wants to know how follow this:
replace the lines 930-943 from "SABnzbd\interfaces\Plush\templates\static\javascripts\plush.js"

Code: Select all

  // NZB individual removal
  $('#history').delegate('.sprite_ql_cross','click', function(event) {
    $('#delete_nzb_modal_title').text( $(this).parent().prev().prev().children('a:first').text() );
    $('#delete_nzb_modal_job').val( $(this).parent().parent().attr('id') );
    $('#delete_nzb_modal_mode').val( 'history' );
    if ($(this).parent().parent().children('td:first').children().hasClass('sprite_hv_star'))
      $('#delete_nzb_modal_remove_files').button('disable');
    else
      $('#delete_nzb_modal_remove_files').button('enable');
    $.colorbox({ inline:true, href:"#delete_nzb_modal", title:$(this).text(),
      innerWidth:"600px", innerHeight:"150px", initialWidth:"600px", initialHeight:"150px", speed:0, opacity:0.7
    });
    return false;
  });

with this (will occupy lines 930-946):

Code: Select all

  // NZB individual removal
  $('#history').delegate('.sprite_ql_cross','click', function(event) {
    $('#delete_nzb_modal_title').text( $(this).parent().prev().prev().children('a:first').text() );
    $('#delete_nzb_modal_job').val( $(this).parent().parent().attr('id') );
    $('#delete_nzb_modal_mode').val( 'history' );
    if ($(this).parent().parent().children('td:first').children().hasClass('sprite_hv_star')) {
     	//$('#delete_nzb_modal_remove_files').button('disable'); // Disabled this to change the behavior to Remove NZB directly on successful downloads
     	$('#delete_nzb_modal_remove_nzb').click();
    }
    else {
      $('#delete_nzb_modal_remove_files').button('enable');
	    $.colorbox({ inline:true, href:"#delete_nzb_modal", title:$(this).text(),
	      innerWidth:"600px", innerHeight:"150px", initialWidth:"600px", initialHeight:"150px", speed:0, opacity:0.7
	    });
	  }
    return false;
  });