[0.7.0b5] traceback after downloader timeout?

[jcfp]

With todays downloads, there were some timeouts during downloading, probably as a result of issue with my isp. This caused the following traceback to show up a couple of times:

Exception in thread Thread-3:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
self.run()
File "/usr/share/sabnzbdplus/sabnzbd/downloader.py", line 308, in run
if nw.nntp.error_msg or (nw.timeout and time.time() > nw.timeout):
AttributeError: 'NoneType' object has no attribute 'error_msg'

Everything seemed to continue normally otherwise.

[shypike]

Hmmm, sloppy programming.
Or the result of a race condition. I'll look into it.
The exception itself is easy to work around.
Was this an "optional" server?

[jcfp]

Was this an "optional" server?

Yes, must have been since all servers are set optional in my install.

[shypike]

For optional I now have a hunch about what can go wrong, only so far I haven't been able to reproduce the scenario.
I will fix the crashing code anyway.

[jcfp]

Probably not easy to reproduce indeed. Some background info: turns out my provider thought I had been uploading "excessive" amounts of data, and figured it would be a good "punishment" to limit my upstream to 128 kbit/s (down from 100 mbit/s). That resulted in a sab install setup for high speed downloading now being insanely cut off by limited upload bandwidth, and even then this traceback happened only a few times after hours of downloading.