Removing sample files should be done post-processing

[onebinary]

(I consider this to be a bug of sorts, but technically it's a Feature Request, although you could make the argument that this is a design/workflow bug)

Some people choose to put the 'extraneous' files under a separate par2 set, including sample files as shown below.  Because these files are not compressed/rar'ed if you have the 'ignore sample files' option enabled the sample file is never downloaded, which ends up causing the par2 repair to fail (and causing the whole item to not proceed with post-processing, which I think is the standard setup for most people).  This kind of leads to a catch22.

Code: Select all

Stage Par2
    [PAR-INFO] filenamefix.proof: => Repaired in 0.0s
    [PAR-INFO] filename-OTHER: => Not enough repair blocks left (have: 0, need: 17)
    [PAR-INFO] filename: => Verified in 9.4s, all files correct
    [DEL-INFO] filenamefix.proof: => Deleted 3 file(s)
    [DEL-INFO] filename: => Deleted 2 file(s)

Code: Select all

onebinary@home:/data/sabnzbd/done/_FAILED_Filename $ par2 r filename-OTHER.par2
...
Verifying source files:

Target: "filename.jpg" - missing.
Target: "filename.nfo" - found.
Target: "filename.sample.avi" - missing.
Target: "filename.sfv" - found.

Scanning extra files:

Repair is required.
2 file(s) are missing.
2 file(s) are ok.
You have 2 out of 28 data blocks available.
You have 9 recovery blocks available.
Repair is not possible.
You need 17 more recovery blocks to be able to repair.

I have had this issue cause post-processing failure on at least 3 occasions. I propose that sample files be removed after post-processing, in the same manner which is used for the Cleanup List.  It might actually be beneficial to fold the sample file option into the Cleanup List as a sub-option (checkbox for sample files or something).

[shypike]

Removing after downloading is counter-productive, as most people want to avoid the download.
Most uploaders make the samples a separate set with its own par2 files, and in that case
our method works fine.

An uploader who combines the normal files and the samples is a fool,
because the purpose of the samples is that you download and check them before
downloading the full data.

So if you encounter many of these jobs, you probably have to disable the feature
and use a user script to remove samples.