folder_max_length affects files since 0.7.17

Report & discuss bugs found in SABnzbd
Forum rules
Help us help you:
  • Are you using the latest stable version of SABnzbd? Downloads page.
  • Tell us what system you run SABnzbd on.
  • Adhere to the forum rules.
  • Do you experience problems during downloading?
    Check your connection in Status and Interface settings window.
    Use Test Server in Config > Servers.
    We will probably ask you to do a test using only basic settings.
  • Do you experience problems during repair or unpacking?
    Enable +Debug logging in the Status and Interface settings window and share the relevant parts of the log here using [ code ] sections.
Post Reply
n2k
Newbie
Newbie
Posts: 38
Joined: March 29th, 2011, 4:38 pm

folder_max_length affects files since 0.7.17

Post by n2k »

since 0.7.17, folder_max_lengthstarted truncating file names
I've set it at 64 instead of default 128, using sabnzbd on Windows 7 SP1.

When I download this NZB, and after post-processing is done (it's extracted in my Completed Download Folder), some file names are truncated, their extension and some characters at the end are gone.

This doesn't happen when I reset the value of folder_max_length to 128 (only tested for the NZB listed above)

When it is has the default value (128) and I download this NZB it'll fail, so that's why I was using a lower setting of 64

--------

Some suggestions
  1. why not make sabnzbd smart about total path length, the folder_max_length is only used for folders, not for files inside those folders, this isn't really fool proof.
    I'm not saying it should rename the files, but if the total length of the path is longer than the technical 260 limit, it should truncate the folder some more.
  2. separate the Temporary Download Folder name structure from the Completed Download Folder, this will allow to store the names and/or structure of what is being downloaded while using smaller temporary folder & file names.
  3. use the \\?\ prefix, which should be supported by python
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: folder_max_length affects files since 0.7.17

Post by shypike »

The problem has been fixed for the next release.
n2k
Newbie
Newbie
Posts: 38
Joined: March 29th, 2011, 4:38 pm

Re: folder_max_length affects files since 0.7.17

Post by n2k »

Neat! I was wondering though, will there be any changes to this or will it just not affect files ;D ?
User avatar
shypike
Administrator
Administrator
Posts: 19774
Joined: January 18th, 2008, 12:49 pm

Re: folder_max_length affects files since 0.7.17

Post by shypike »

It should not affect actual file names.
Post Reply