bug in 0.5; it stops

[ugokanain]

shypike,
The server that has the parts is one of the regular servers (not optional, not fill server).  Though it did pick up some parts from optional servers. I have 3 no fills, not optional servers, and all others are both (fill and optional). However, the segments were only available from one server.

When I set the priority to low, it sends the post to the end of the queue. That lead me to believe it was that post that caused sab to freeze. When it is at the top of the queue, other files download but eventually sab stops working.

It isn't something that happens all the time, just with some post. After a bunch of restarts (depending on the size of the file), it dls all of the file and then works without a hitch. Have the impression that even if I sent you the nzb, you might not have the same problem.

[shypike]

I have a hunch (already for a long time) about what the cause is.
I just cannot find where to tweak the code to solve it.
Primarily because I have never been able to reproduce it.
Which doesn't mean it doesn't happen to other people.

The last change I did (the potential crash) could be the solution,
but I have my doubts because it's such an unlikely scenario.

Keep me informed if it happens again.

You are very likely right that it's not the NZB.
Can you email it anyway, just to be sure?

[ugokanain]

I am running rc4 and it happened again.  Did notice a problem at the connection window, but probably it is unrelated

Failed to connect: (60, '[Errno 61] Connection refused') in one of the servers. The other two show to be connected, though they haven't been for a while. The speed indicator in the web shows 0 and seems that the menu in osx is now working and is also showing 0. Used to show the last connection speed.

I am sending you the two nzb I think might be related, however might be more the combination of the server and nzb

Usually when it stops, I can't quit. I have to kill it. When it has finished nicely, there is no problem with quitting sab

Not related, but I am not getting notified. When I press the notify botton in the forum it asks if I want to cancel.

[shypike]

Not related, but I am not getting notified. When I press the notify botton in the forum it asks if I want to cancel.

The notify is a toggle.
It ask either whether you want notifications or whether you want to cancel notifications.
Check your forum profile's "Notifications and Email" tab.

[shypike]

The smaller download was missing completely on astraweb, but OK on giganews.
The only way I can make it "hang" is like this:
giganews : non-optional and non-backup
absent server : non-optional and backup
hacking the NZB by changing one of the article identifiers.
Now it will hang waiting for the last article.
This mimicks the situation where the some of the articles have already dropped from the server(s).
The bad shutdown behaviour you report, I cannot see.
OK, it does take longer because the downloader insists on timing out all connections
to the non-existing server.
BTW: the "smpl" skin has a worse shutdown behaviour.

Is your server setup anything like this?
Having a non-optional server not responding is fatal in this case.
Can you see that it keeps retrying a server or is everything just dead?
Do new messages keep appearing in the log file?

[shypike]

I do have a deadlock now.
After changing the dead server to optional and waiting for
the server block to occur, the job does not finish.
The queue is idle.

Well, off to the debugging. This will be quite a challenge,
but at least I have reproduced something.

EDIT:
** I think I have found the actual cause **
Will take quite some testing to ensure the fix doesn't have side effects.

[ugokanain]

my free servers are set as optional fill, but my paid servers are set as non fill, non backup servers. On one of the nzbs, only one of the three servers had the post.

I am glad that you found what the problem is, but sorry that it has turn to be such a mess

[shypike]

I solved it.
At least if what I found is actually the cause of your halts.
Hard to tell from here.
I'll include it in the next RC.

The download queue is due for a grand redesign,
but until we manage that, fixes like these are needed
to solve the visible problems.

[ugokanain]

Thanks and congrats.

This has been something that has been popping up from time to time. Now my problem will be getting a larger drive
Thanks

[ugokanain]

Just to confirm, I just dl the two files that had given me trouble. They dled without a hitch.