Page 1 of 1

Nzb Checker issue?

Posted: April 19th, 2012, 7:51 am
by tymanthius
Noticed this on a movie I tried to download last night:

ยป Download would not be successful, only 100.0% available

I'm a little curious how a 100% available download could fail. :D

Let me know how I can give additional info so you can troubleshoot. :)

This Beta3 running on Ubuntu 10.04 headless server.

Re: Nzb Checker issue?

Posted: April 19th, 2012, 8:44 am
by sander
Hahaha! Could that be the rounded form of something like "only 99.95% available"? So rounded from two (or more) decimals to one decimal?

Re: Nzb Checker issue?

Posted: April 19th, 2012, 9:10 am
by shypike
It could be a rounding error. Even a single byte short would still mean unrepairable.
However, keep in mind that the check can never be 100.000% accurate.
It's up to you to decide.
Having said that, 100.0% should not have been shown here, precisely because it is unclear.
99.9% should be the maximum number shown.

Re: Nzb Checker issue?

Posted: April 19th, 2012, 9:21 am
by tymanthius
shypike wrote:It could be a rounding error. Even a single byte short would still mean unrepairable.
However, keep in mind that the check can never be 100.000% accurate.
It's up to you to decide.
Having said that, 100.0% should not have been shown here, precisely because it is unclear.
99.9% should be the maximum number shown.

Kind of what I thought. Not a big deal really, but I thought I'd bring it to your attention as this is still a very new feature.

Re: Nzb Checker issue?

Posted: April 19th, 2012, 10:53 am
by sander
shypike wrote: Having said that, 100.0% should not have been shown here, precisely because it is unclear.
99.9% should be the maximum number shown.

Code: Select all

ratio = 0.9995

emsg = '%.1f%%' % (ratio * 100.0)
emsg = 'Download would not be successful, only %s available' % emsg
print emsg


emsg = '%d%%' % (ratio * 100.0)
emsg = 'Download would not be successful, only %s available' % emsg
print emsg
with the following result:

Code: Select all

sander@R540:~$ python wwwww.py 
Download would not be successful, only 100.0% available
Download would not be successful, only 99% available
sander@R540:~$
So using %d gives two better results:
- rounding down, no more "100.0%"
- no false idea that the measurement is exact in 1 decimal after the point

Re: Nzb Checker issue?

Posted: April 19th, 2012, 10:57 am
by shypike
Fixed for the next Beta.

Re: Nzb Checker issue?

Posted: April 19th, 2012, 11:04 am
by tymanthius
Awesome! Thanks guys!