SABnzbd Forums

Nice to see a (pre-)release. So far, so good: haven't gotten it to crash or misbehave yet. After a short warning about upgrading the queue it has been business as usual.

Some notes I took along the way:

• Obvious minor translation issue%s:

  Code: Select all

  python tools/make_mo.py
  WARNING: %s mismatch, skipping!
      Trying unrar with password "%s"
      Проба испакивања са лозинком joinable
  WARNING: %s mismatch, skipping!
      Trying 7zip with password "%s"
      Forsøger 7zip med password "% s"
  WARNING: %s mismatch, skipping!
      7ZIP set "%s" is incomplete, cannot unpack
      7ZIP sæt "% s" er ufuldstændig, kan ikke udpakke
  WARNING: %s mismatch, skipping!
      Could not unpack %s
      Kan ikke udpakke &s

• cherrypy/VERSION.txt seems to imply the included cherrypy is a vanilla release (minus a few trivial deletions) as available at the given url, but it appears to have several non-trivial patches (utf support, file upload fix, etc). Please expand the document to prevent issues for packagers.
• Per-server statistics (the ones visible in the config) were reset to zero on first run of 0.8.x. Assuming this is a known side-effect or otherwise intentional?
• For my understanding: the 7zip support deals with 7z archives only, i.e. it's never used to unrar? (and just for the record: I'm not saying it should)
• Much of the install documentation in the release needs an extreme makeover. Many optional modules are missing entirely (gtk2/gobject for systray, the bonjour/zeroconf/avahi stuff) and info outdated (such python version 2.5 listed as supported while the code says otherwise). I'll try to make a pull request out of that stuff if/when free time meets bad weather.

Translations: I thought I had those covered

CherryPy: I'm looking at a more recent CherryPy release.
Unfortunately it seems they cannot ever release something that doesn't require patching.

Resetting counters: may have missed that one. I'll look into it.

7zip for unrar. The problem that 7zip is always a bit behind with RAR formats, which is understandable of course.
Would there be benefits using 7zip?

I don't look often enough at the "install.txt" file. It is outdated.
I was in a bit of a hurry to finally get something out of the door.

The uploaded source tar.gz is wrong.
I just uploaded a new one: SABnzbd-0.8.0Alpha1-FIXED-src.tar.gz

This will fix the translation errors, not the other issues.

You're not going to like me for saying this, but uhm... the FIXED-src.tar.gz needs fixing.
It contains an osx dir with several binaries (and a symlink that escapes the root dir of the extracted archive earning it a lintian hit).

shypike wrote:7zip for unrar. The problem that 7zip is always a bit behind with RAR formats, which is understandable of course.
Would there be benefits using 7zip?

Not that I know, just asked so I get the dependencies right. All clear now.

Yeah, I've been way too sloppy with the source archive.
I changed around some things and did not pay close enough attention to the end result.
I'm lucky that your eagle eyes find such things, but I should have done better.
Uploaded SABnzbd-0.8.0Alpha1-FIXED2-src.tar.gz

Another not so major one:

Something seems wrong with the processing of the path's on Windows? It add's this \\?\ to the start of the path internally? It's definitely not in the config.
Error renaming "\\?\D:\All Downloads\Completed Downloads\_UNPACK_mad men" to "\\?\D:\All Downloads\Completed Downloads\mad men"

It's also in the Path reported with the API in the history.

safihre wrote:Another not so major one:

Something seems wrong with the processing of the path's on Windows? It add's this \\?\ to the start of the path internally? It's definitely not in the config.
Error renaming "\\?\D:\All Downloads\Completed Downloads\_UNPACK_mad men" to "\\?\D:\All Downloads\Completed Downloads\mad men"

It's also in the Path reported with the API in the history.

""\\?\" is correct Windows style for long long and/or unicode paths. See https://msdn.microsoft.com/en-us/librar ... s.85).aspx :

To specify an extended-length path, use the "\\?\" prefix. For example, "\\?\D:\very long path".

So if it doesn't work within SABnzbd (it's new in 0.8.x), that is indeed a bug in SABnzbd. Isn't there a module name & line number in the error message?

Oh it does work, just looks weird
The renaming error I got is probably a permissions-issue on my specific PC.