Page 1 of 1

Join files before verification

Posted: January 1st, 2010, 5:29 pm
by dalek
Version: 0.5.0 beta 5
OS: OpenBSD 4.6
Install-type: from source
Skin (if applicable): Classic?
Firewall Software: pf
Are you using IPV6?: No
Is the issue reproducible? yes

I'm unsure if this a bug or a feature. When an nzb contains  file.001, file.002 etc and par2 recovery files,
repair fails if the recovery files have been made from file instead of the split parts. Is it possible to join the files before verification?

Re: Join files before verification

Posted: January 1st, 2010, 6:57 pm
by inpheaux
[Edit: i take all that back. par2 is, in fact, magical.]

Ok, the problem here is that based on the output of par2 I don't think we can tell the difference between something that's ok, but was par'ed out of order, and something that's just gone. We'd probably have to add some stuff to Quick Check where we look at the files we have, look at the files the par describes, and then make some iffy assumptions.

Even if we wrote something to handle this edge case, I'm not sure I'd trust it.

It's an edge case, the person who posted it doesn't know how you're supposed to do this stuff, I don't think it'd be a great idea to try to cater to it.

Re: Join files before verification

Posted: January 2nd, 2010, 6:21 am
by shypike
PAR2 will automatically "join" files when necessary.
This is fully supported by SABnzbd.
It happens when the poster splits the main file after creating the par2 files.

Do you have an example NZB showing that this fails?
If so, please email to bugs at sabnzbd.org