0.5.0 Newzbin bookmarks not removed

[Juice]

Version: 0.5.0
OS: Linux (gentoo)
Install-type: python source
Skin (if applicable): Not applicable (but Plush)
Firewall Software: none
Are you using IPV6? no
Is the issue reproducible? yes

0.5.0 (and previous beta's I think) doesn't remove downloaded bookmarks from Newzbin's bookmarks list when the 'Auto-Fetch Bookmarks' option is disabled. With the option enabled, behaviour is as expected.

Not a real bug maybe, just a nuisance (I don't use auto fetch, just use the manual 'get bookmarks now' option). 

[shypike]

The bookmarks are only deleted after the download completes
and only when you set the "un-bookmark" option.

[Juice]

That's understood, but it's not what I meant. I'll try and be a bit more clear. This is all using the 'Get Bookmars Now' function.

Auto-Fetch ON -> Un-Bookmark ON -> download complete -> bookmark IS deleted
Auto-Fetch OFF -> Un-Bookmark ON -> download complete -> bookmark IS NOT deleted

Anyway, I changed line 81 in newzbin.py from

Code: Select all

if __BOOKMARKS and cfg.NEWZBIN_BOOKMARKS.get() and cfg.NEWZBIN_UNBOOKMARK.get():

into

Code: Select all

if __BOOKMARKS and cfg.NEWZBIN_UNBOOKMARK.get():

and that solves it for me. I don't suppose this change will do any other harm, but if so, please advise.

[shypike]

OK, sorry for being a bit dimwitted.
I see the problem now and this is probably the right fix.
When this was implemented the focus was on the automated scan
and the button was added as an afterthought (for testing).
Will fix this in next release (0.5.1).