Page 1 of 1

PATCH -> Fixed Position for Left-Side Menu (i.e. ALWAYS on Screen)

Posted: March 15th, 2011, 8:32 pm
by DEMONiX
Hiya,  :D

On some long-vertical screens, e.g. especially when editing a NZB, I hate having to scroll down to select some files, and then having to scroll all the way to the top to access the selection options ('range', 'invert', 'delete', etc). 

So, I've attached a patch that adds the CSS:

Code: Select all

position: fixed;
to Plush's 'gold.css' file. 

This way, the left-hand menu always stays on screen, even as you scroll! 

I've tested the patch - I ran it from just within the root sabnzbd folder  (the patch contains the full path to the gold.css from the root sabnzbd folder)
Tested command: 

Code: Select all

patch -p1 < gold.css.patch
(Note - the forum software does not let me upload a .patch, so I've appended .txt - just be aware of that)


I should mention that this is my *first* ever contribution to an open source project! 
It's also my first time using diff & patch (just taught myself it today!). 
I'm so happy - it's not much for a contribution, but it's my first, on my favourite open-source project, actually adding a useful (but simple) feature! 

Woohoo!  ;D

Re: PATCH -> Fixed Position for Left-Side Menu (i.e. ALWAYS on Screen)

Posted: March 16th, 2011, 8:22 am
by DEMONiX
Hiya,

I've attached a screenshot - as you can see from the scrollbar on the right side, the viewport is currently only viewing a small part of the total NZB, and there would have been a lot to scroll up!

The fix is applied, and as you can see, the menu stays on the left hand side for easy access.

(I should have mentioned, I'm using Ubuntu, installed via PPA, and I've tested this fix in Chromium (Google Chrome), and Firefox.  I have not got access to IE).


Thanx for the development links - I can't believe I forgot all about Launchpad!

I looked around for where to submit the patch - my search ended at this page: http://sabnzbd.org/contribute/
and that page basically said go to the forum.

I think we should add some of the development links you've provided to that page?

Thanx

Re: PATCH -> Fixed Position for Left-Side Menu (i.e. ALWAYS on Screen)

Posted: March 16th, 2011, 9:58 am
by DEMONiX
I've also attached another screenshot showing the same thing, but on the settings > switches page. 

As you can see, it makes like a lot (well, a little) easier.

Thanx

Re: PATCH -> Fixed Position for Left-Side Menu (i.e. ALWAYS on Screen)

Posted: March 16th, 2011, 11:08 am
by shypike
Good initiative and we'll have a closer look at this.
Hopefully it will work on all supported browsers.

Re: PATCH -> Fixed Position for Left-Side Menu (i.e. ALWAYS on Screen)

Posted: March 17th, 2011, 5:38 pm
by shypike
OK, added to the next Beta.
Thanks!